Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: Ogury #4082

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

New Adapter: Ogury #4082

wants to merge 11 commits into from

Conversation

krdzo
Copy link

@krdzo krdzo commented Nov 28, 2024 •
edited
Loading

PR for the documentation prebid/prebid.github.io#5742

github-actions[bot]
github-actions bot reviewed Nov 28, 2024
View reviewed changes
adapters/ogury/ogury.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, cfc66d0

ogury

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:28:	MakeRequests		75.7%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:119:	filterValidImps		92.9%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:149:	getAdUnitCode		87.5%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:164:	setHeaders		57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:176:	getMediaTypeForBid	57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:196:	MakeBids		70.0%
total:								(statements)		75.8%

@krdzo krdzo mentioned this pull request Nov 29, 2024
Merged
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1125795

ogury

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:26:	MakeRequests		75.7%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:117:	filterValidImps		92.9%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:147:	getAdUnitCode		87.5%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:162:	setHeaders		57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:174:	getMediaTypeForBid	57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:194:	MakeBids		70.0%
total:								(statements)		75.5%

@krdzo krdzo mentioned this pull request Nov 29, 2024
Open
2 tasks
@krdzo
Copy link
Author

krdzo commented Dec 3, 2024

Hello I have a question with this PR.
We are using adUnitCode in our backend and I wanted to read it from imp[].Ext.Prebid.AdUnitCode but I see that this field is not forwarded to bidders (also opened this issue #4077 to see if this is a bug or intended behaviour), so we using imp.Id as a fallback for adunitcode.
Is this a right assumption, can we relay on imp[].id to always have adUnitCode?

@krdzo krdzo mentioned this pull request Dec 11, 2024
Open
@krdzo
remove adunitcode mapping
2289c6c 
always use imp.id for adunitcode, to map to imp.tagid
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2289c6c

ogury

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:25:	MakeRequests		74.3%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:113:	filterValidImps		92.9%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:143:	setHeaders		57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:155:	getMediaTypeForBid	57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:175:	MakeBids		70.0%
total:								(statements)		73.8%

SyntaxNode
SyntaxNode reviewed Dec 12, 2024
View reviewed changes
static/bidder-info/ogury.yaml
- global
maintainer:
email: [email protected]
gvlVendorID: 31
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified GVL ID.

adapters/ogury/ogury.go Outdated Show resolved Hide resolved
adapters/ogury/ogury.go Outdated Show resolved Hide resolved
adapters/ogury/ogury.go Outdated Show resolved Hide resolved
adapters/ogury/ogury.go Show resolved Hide resolved
adapters/ogury/ogury.go Show resolved Hide resolved
@SyntaxNode
Copy link
Contributor

Hello I have a question with this PR. We are using adUnitCode in our backend and I wanted to read it from imp[].Ext.Prebid.AdUnitCode but I see that this field is not forwarded to bidders (also opened this issue #4077 to see if this is a bug or intended behaviour), so we using imp.Id as a fallback for adunitcode. Is this a right assumption, can we relay on imp[].id to always have adUnitCode?

Let's leave the discussion on the mentioned issue.

@krdzo
ADV-20406 address pr comments (#12)
119a517 
* use jsonutil package instead standard json lib

* don't allocate newImpExt, use impExt for hoisting bidder.params

* rename to buildHeader

* set IPv6 header

* use mtype from response
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 119a517

ogury

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:26:	MakeRequests		71.0%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:106:	filterValidImps		92.9%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:136:	buildHeaders		50.0%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:149:	getMediaTypeForBid	33.3%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:166:	MakeBids		70.0%
total:								(statements)		70.0%

@krdzo
Copy link
Author

krdzo commented Dec 16, 2024

@SyntaxNode I pushed changes to address comments on PR
Can you take a look again at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@SyntaxNode SyntaxNode SyntaxNode left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krdzo @SyntaxNode